Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: remove runtime subcommand #626

Merged
merged 1 commit into from
Jun 26, 2024
Merged

cli: remove runtime subcommand #626

merged 1 commit into from
Jun 26, 2024

Conversation

davidweisse
Copy link
Contributor

This removes the runtime subcommand from the CLI, as the runtime handler will now be printed with the --version command.

@davidweisse davidweisse requested a review from burgerdev June 24, 2024 12:34
@davidweisse davidweisse requested a review from katexochen as a code owner June 24, 2024 12:34
@davidweisse davidweisse added the changelog PRs that should be part of the release notes label Jun 24, 2024
@katexochen katexochen added breaking change A user-affecting breaking change and removed changelog PRs that should be part of the release notes labels Jun 24, 2024
burgerdev
burgerdev reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@burgerdev burgerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this depend on another PR? I don't see the runtime in the --version output.

@davidweisse davidweisse force-pushed the dav/remove-runtime-subcommand branch from 7dc9cb4 to 341aece Compare June 24, 2024 12:58
@davidweisse davidweisse requested a review from burgerdev June 25, 2024 13:52
@burgerdev
Copy link
Contributor

Does this depend on another PR? I don't see the runtime in the --version output.

Is this addressed now?

@katexochen
Copy link
Member

Does this depend on another PR? I don't see the runtime in the --version output.

Is this addressed now?

looks like it:

❯ nix run .#contrast.cli -- --version
contrast version v0.8.0-pre

    runtime handler:      contrast-cc-beee79ca916b9e5dc59602788cbfb097
    launch digest:        beee79ca916b9e5dc59602788cbfb097721cde34943e1583a3918f21011a71c47f371f68e883f5e474a6d4053d931a35
    genpolicy version:    3.2.0.azl1.genpolicy0
    image versions:

@davidweisse davidweisse merged commit 06c79a9 into main Jun 26, 2024
8 checks passed
@davidweisse davidweisse deleted the dav/remove-runtime-subcommand branch June 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@burgerdev burgerdev Awaiting requested review from burgerdev

Assignees
No one assigned
Labels
breaking change A user-affecting breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidweisse @burgerdev @katexochen